[
https://issues.apache.org/jira/browse/CB-12677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16093152#comment-16093152
]
ASF GitHub Bot commented on CB-12677:
-------------------------------------
GitHub user russaa opened a pull request:
https://github.com/apache/cordova-android/pull/396
CB-12677: (android) added option for explicitly specifying path to An…
<!--
Please make sure the checklist boxes are all checked before submitting the
PR. The checklist
is intended as a quick reference, for complete details please see our
Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
android
### What does this PR do?
Adds the option for explicitly specifying the path to Android Studio via
env variable.
Automatic detection of the _Android Studio_ path currently only works, if
it is installed in the default location.
The option to specify the path via an env variable offers a simple
solution, in cases where automatic detection does not work.
This solution relates to [issue & discussion
CB-12677](https://issues.apache.org/jira/browse/CB-12677).
### What testing has been done on this change?
manually tested
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform
affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mmig/cordova-android CB-12677
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-android/pull/396.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #396
----
commit 4bf60983ff7e698f279e7790cc2e8947bd4bf754
Author: russa <aaron.r...@dfki.de>
Date: 2017-07-19T13:56:42Z
CB-12677: (android) added option for explicitly specifying path to Android
Studio via env variable
----
> `cordova requirements android` fails when Android Studio is in "Program
> Files" instead of "Program Files (x86)"
> ---------------------------------------------------------------------------------------------------------------
>
> Key: CB-12677
> URL: https://issues.apache.org/jira/browse/CB-12677
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-android
> Affects Versions: 6.2.1
> Environment: Windows 7, 64-bit
> Android Studio 2.3.1
> cordova 6.5.0
> cordova-android 6.2.1
> Reporter: jakub-g
> Labels: android-next
>
> See http://stackoverflow.com/a/43523141/245966
> basically on my machine in `cordova/lib/check_reqs.js`:
> {code}
> process.env['ProgramFiles'] === 'C:\\Program Files (x86)'
> {code}
> whereas I have android studio in `C:\Program Files` and I think I might not
> be the only one with the same problem.
> In fact on my machine I have the following folders somehow:
> {code}
> C:\Program Files\Android\Android Studio
> C:\Program Files (x86)\Android\android-sdk
> {code}
> (The second folder is some leftovers from old installation, not used anymore;
> I keep things in `D:\java\android\sdk` since quite a while)
> What would be a good fix in your opinion, other than checking both folders?
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
