[
https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16108148#comment-16108148
]
ASF GitHub Bot commented on CB-12895:
-------------------------------------
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/41
CB-12895: replaced jshint with eslint
<!--
Please make sure the checklist boxes are all checked before submitting the
PR. The checklist
is intended as a quick reference, for complete details please see our
Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
### What does this PR do?
replaced jshint with eslint
### What testing has been done on this change?
### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform
affected.
- [X] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/audreyso/cordova-plugin-wkwebview-engine
CB-12895
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/41.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #41
----
commit b2b121b856d0ea92fadca6cae5d8ff283c68f40f
Author: Audrey So <audre...@apache.org>
Date: 2017-06-12T18:59:35Z
CB-12895 : added eslint and removed jshint
commit 919dbcec374b3a7ebab0131da9870ec25cb10db2
Author: Audrey So <audre...@apache.org>
Date: 2017-07-31T20:52:59Z
CB-12895 : rebased and updated files
----
> Replace jshint with eslint in our tools + platforms
> ---------------------------------------------------
>
> Key: CB-12895
> URL: https://issues.apache.org/jira/browse/CB-12895
> Project: Apache Cordova
> Issue Type: Improvement
> Components: AllComponents
> Reporter: Steve Gill
> Assignee: Audrey So
> Priority: Minor
> Labels: cordova-next
>
> Based on this proposal
> https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308
> JSHint does minimal checks and JSCS has been deprecated in favor of ESLint.
> +
> +I suggest to replace the current style checkers with ESLint. This allows to
> set much more strict styling rules than at at this moment.
> +
> +I recommend using a popular preset, such as
> [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base).
> Example configuration:
> +
> +```yaml
> +root: true
> +
> +extends: airbnb-base
> +```
> +
> +Many styling issues could be fixed by simply running:
> +
> +```
> +./node_modules/.bin/eslint --fix .
> +```
> +
> +
> +
> +Optionally the indent could be set to 4 instead of 2, because that's used
> in the current code base.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
