[ https://issues.apache.org/jira/browse/CB-12834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16130148#comment-16130148 ]
ASF GitHub Bot commented on CB-12834: ------------------------------------- Github user adirel commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/221 Hi @RafaelKr, Few points about old devices. the app crash whith error on line 109 at In: cordova-plugin-inappbrowser\www\inappbrowser.js **the code:** + let windowFeatures = { + width: isNumeric(size.width) ? size.width : null, + height: isNumeric(size.height) ? size.height : null + }; **error recived:** D/SystemWebChromeClient( 8784): file:///android_asset/www/plugins/cordova-plugin-inappbrowser/www/inappbrowser.js: Line 109 : Uncaught SyntaxError: Block-scoped declarations (let, const, function, class) not yet supported outside strict mode I/chromium( 8784): [INFO:CONSOLE(109)] "Uncaught SyntaxError: Block-scoped declarations (let, const, function, class) not yet supported outside strict mode", source: file:///android_asset/www/plugins/cordova-plugin-inappbrowser/www/inappbrowser.js (109) > Opening a link to a file in the inappbrowser on Android crashes the app > ----------------------------------------------------------------------- > > Key: CB-12834 > URL: https://issues.apache.org/jira/browse/CB-12834 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-inappbrowser > Environment: Android > 4.4 > Reporter: Mèir Noordermeer > Priority: Critical > Labels: android, cordova, download, inappbrowser > Original Estimate: 2h > Remaining Estimate: 2h > > When opening a link to a a file (a PDF, for example) the inappbrowser > crashes, because on Android versions of 4.4 storage permissions are not > automatically granted anymore. Thus these should be requested instead of > letting the app crash. > I am creating this issue to follow the guidelines of pull requests. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org