[
https://issues.apache.org/jira/browse/CB-13309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16191015#comment-16191015
]
Jan Piotrowski (Sujan) commented on CB-13309:
---------------------------------------------
I looked at the PR and I have to say, this is _so_ much better than the current
state. Nice!
> Make InAppBrowser a Library Module for easier maintenance
> ---------------------------------------------------------
>
> Key: CB-13309
> URL: https://issues.apache.org/jira/browse/CB-13309
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-plugin-inappbrowser
> Reporter: Joe Bowser
>
> We currently just copy in Java files directly in a project, but that has some
> major problems with layouts and resources. Now that Android allows Library
> Projects, we can now add modules as plugins and allow for certain plugins
> which require layouts (like the InAppBrowser) to define them in XML instead
> of programmatically, which will allow for a lot of code to be deleted from
> the project, and for the project to be easier to maintain for Android.
> Another upshot of this change is that we can then add JUnit and Espresso
> Integration Tests to plugins so that we can actually test plugin changes the
> same way we run native tests on Android with the Android Test Project.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
