[ 
https://issues.apache.org/jira/browse/CB-13424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16200792#comment-16200792
 ] 

ASF GitHub Bot commented on CB-13424:
-------------------------------------

Github user JoseExposito commented on the issue:

    https://github.com/apache/cordova-osx/pull/43
  
    Indeed, the logic comes from iOS/Android.
    
    Basically, I updated the cordova-common library to match the iOS version 
and used it in the plugin add/remove hooks like other platforms are doing.
    
    In my opinion the macOS platform will need more updates to match the 
structure other platforms are using... But for the moment this fixes the issue. 
Once I see if the team is open to community PRs you can expect more changes :)


> [cordova-osx] Not adding plugins to the osx platform
> ----------------------------------------------------
>
>                 Key: CB-13424
>                 URL: https://issues.apache.org/jira/browse/CB-13424
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-osx
>            Reporter: José Expósito
>            Assignee: Tobias Bocanegra
>            Priority: Blocker
>
> cordova plugin add does not work on macOS.
> It is necessary to open "platforms/osx/HelloCordova.xcodeproj" and manually 
> add the plugin to "platforms/osx/HelloCordova/config.xml":
> {code}
> <?xml version='1.0' encoding='utf-8'?>
> <widget id="io.cordova.hellocordova" version="1.0.0" 
> xmlns="http://www.w3.org/ns/widgets"; 
> xmlns:cdv="http://cordova.apache.org/ns/1.0";>
>     [...]
>     <feature name="Device">
>         <param name="osx-package" value="CDVDevice" />
>     </feature>
>     [...]
> </widget>
> {code}
> I noticed this happens with Cordova core plugins with official macOS support 
> like cordova-plugin-device or cordova-plugin-file.
> Also experimented while migrating cordova-plugin-camera:
> https://github.com/apache/cordova-plugin-camera/pull/290



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to