[
https://issues.apache.org/jira/browse/CB-13555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16244606#comment-16244606
]
ASF GitHub Bot commented on CB-13555:
-------------------------------------
jonathanli2 opened a new pull request #98: CB-13555 (ios) Present notification
view controller by inappbrowser view controller
URL: https://github.com/apache/cordova-plugin-dialogs/pull/98
…resented
<!--
Please make sure the checklist boxes are all checked before submitting the
PR. The checklist
is intended as a quick reference, for complete details please see our
Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
iOS
### What does this PR do?
Fix the issue of not showing the dialog screen if inappbrowser screen is
presented
[https://issues.apache.org/jira/browse/CB-13555](https://issues.apache.org/jira/browse/CB-13555)
### What testing has been done on this change?
Create a cordova ios project with UIWebView or WKWebView, and call the below
method. The dialog view does not show to user.
function confirm(){
var win = window.open( "https://www.google.com";, "_blank" );
win.addEventListener( "loadstop", function() {
setTimeout(function() {
function onConfirm(buttonIndex) {
console.log('You selected button ' + buttonIndex);
}
navigator.notification.confirm(
'You are the winner!', // message
onConfirm, // callback to invoke with index of button
pressed
'Game Over', // title
['Restart','Exit'] // buttonLabels
);
}, 1000 );
});
}
### Checklist
- [Y] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [Y] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform
affected.
- [N] Added automated test coverage as appropriate for this change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> (ios) Present notification view controller by inappbrowser view controller
> --------------------------------------------------------------------------
>
> Key: CB-13555
> URL: https://issues.apache.org/jira/browse/CB-13555
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-dialogs
> Affects Versions: cordova-ios 4.5.0
> Environment: IOS 10 and 11
> Reporter: Jonathan Li
> Labels: dialog, inappbrowser
> Fix For: Master
>
>
> When inappbrowser window is shown, if main uiwebview or wkwebview calls
> cordova Dialog plugin method to show the dialog view, the dialog should show
> to user on top of the inappbrowser view controller.
> However, currently the dialog view is shown behind the inappbrowser view, so
> user cannot see it or click button on the dialog
> An similar issue was reported for barcode scanner plugin at
> https://github.com/phonegap/phonegap-plugin-barcodescanner/issues/570
> The issue can be repeated with the below method
> function confirm(){
> var win = window.open( "https://www.google.com";, "_blank" );
> win.addEventListener( "loadstop", function() {
> setTimeout(function() {
> function onConfirm(buttonIndex) {
> console.log('You selected button ' + buttonIndex);
> }
>
> navigator.notification.confirm(
> 'You are the winner!', // message
> onConfirm, // callback to invoke with index of button
> pressed
> 'Game Over', // title
> ['Restart','Exit'] // buttonLabels
> );
> }, 1000 );
> });
> }
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
