[ 
https://issues.apache.org/jira/browse/CB-13543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16251213#comment-16251213
 ] 

ASF GitHub Bot commented on CB-13543:
-------------------------------------

janpio commented on a change in pull request #760: CB-13543 : updated 
instructions/documentation around travis build/dep…
URL: https://github.com/apache/cordova-docs/pull/760#discussion_r150795285
 
 

 ##########
 File path: doc/building-and-deploying-the-website.md
 ##########
 @@ -0,0 +1,22 @@
+## Building and Deploying (Automated)
+
+### Testing
+
+After you are finished developing and making your changes, make sure to test 
them. Run:
+
+       npm test
+
+`npm test` runs both [eslint] and [mocha] tests. If your tests pass, commit 
and push your work to Github.
+
+### Travis 
+
+[Travis] automatically builds and publishes the website on every change. 
Travis will build the full website for you by running `gulp build --prod` under 
the hood. Travis also uses [SVN] to update, copy, add, and commit the new 
changes over to the website. Committing to svn can only occur once the commit 
has been merged to master. 
+
+Lastly, Travis also runs `npm test` and will notify you if any of your 
`eslint` or `mocha` tests are failing. When Travis is done building and 
deploying, send a pull request and ask for a review.
 
 Review comment:
   Why the seperate "Testing" paragraph if Travis automatically runs the tests? 
Is this a safeguard somehow?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Automate build/deploy for cordova-docs
> --------------------------------------
>
>                 Key: CB-13543
>                 URL: https://issues.apache.org/jira/browse/CB-13543
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: cordova-docs
>            Reporter: Audrey So
>            Assignee: Audrey So
>              Labels: enhancement, feature, in-progress, optimization
>
> Automate build/deploy for cordova-docs
> Cordova-docs should be built and published automatically on every change
> Replace jsihnt with eslint
> Update README.md & update instructions in docs to reflect changes
> https://issues.apache.org/jira/browse/CB-13162



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to