[
https://issues.apache.org/jira/browse/CB-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16315390#comment-16315390
]
ASF GitHub Bot commented on CB-13396:
-------------------------------------
jcesarmobile commented on issue #135: CB-13396: (ios) Fix image sizing on
iPhone X
URL:
https://github.com/apache/cordova-plugin-splashscreen/pull/135#issuecomment-355837438
> this is a different issue
Yes, it's a different issue, but there are a few people in this issue
complaining about the other issue that wasn't reported because it's not clear
that this PR is for when using storyboard and they are not using storyboard.
That's why I created the other issue, fixed it and pointed the people to the
other issue instead of complaining here. My intention is not to pollute this
issue with unrelated comments, it's the opposite, to point them to the right
issue.
> the previous method is old anyways and people should just use the
storyboard one
The old method is still supported and anybody can use whatever they want
> Hence this discussion should not be polluted with unrelated topics.
The other topic is related, the title says "Fix image sizing on iPhone X",
and people enter hopping that it fixes their issues with iPhone X image sizing,
but it doesn't, the other issue fixes it.
Anyway, no discussion should be polluted in PRs, Apache Cordova uses JIRA
for the issues, so all the discussions should be in the related JIRA and not
here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Splash screen images are resized incorrectly on iPhone X
> --------------------------------------------------------
>
> Key: CB-13396
> URL: https://issues.apache.org/jira/browse/CB-13396
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-splashscreen
> Environment: iOS 11 / iPhone X
> Reporter: Ken Mickles
> Labels: splashscreen
>
> CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into
> account, causing the image size to change when CDVLaunchScreen.storyboard
> transitions to the CDVSplashScreen image.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
