[ 
https://issues.apache.org/jira/browse/CB-13641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16332520#comment-16332520
 ] 

ASF GitHub Bot commented on CB-13641:
-------------------------------------

janpio commented on a change in pull request #245: CB-13641: (windows) support 
transparent splash screen background color.
URL: https://github.com/apache/cordova-windows/pull/245#discussion_r162669620
 
 

 ##########
 File path: template/www/cordova.js
 ##########
 @@ -2064,7 +2064,7 @@
         // Revert title bg color
         function revertTitleBarColor () {
             var appView = 
Windows.UI.ViewManagement.ApplicationView.getForCurrentView();
 
 Review comment:
   Ok. I think I can merge this then.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Splash screen on Windows does not allow for transparent background color.
> -------------------------------------------------------------------------
>
>                 Key: CB-13641
>                 URL: https://issues.apache.org/jira/browse/CB-13641
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: cordova-windows
>    Affects Versions: cordova@7.0.0
>         Environment: Windows 10.
>            Reporter: Terence Bandoian
>            Priority: Trivial
>              Labels: newbie
>             Fix For: Master
>
>
> The splash screen background color defaults to #464646.  In splashscreen.js, 
> the background color is expected to be a hex value and values longer than 
> seven characters are spliced to remove the alpha channel.  The configured 
> value could be checked for the value 'transparent' and, in that case, not 
> spliced.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to