[ 
https://issues.apache.org/jira/browse/CB-13818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16340905#comment-16340905
 ] 

ASF GitHub Bot commented on CB-13818:
-------------------------------------

janpio commented on a change in pull request #431: CB-13818: (android) Update 
android_sdk.js to support Android Oreo 8.0 (API 26) emulator
URL: https://github.com/apache/cordova-android/pull/431#discussion_r164084142
 
 

 ##########
 File path: bin/templates/cordova/lib/android_sdk.js
 ##########
 @@ -62,7 +62,8 @@ module.exports.version_string_to_api_level = {
     '5.1': 22,
     '6.0': 23,
     '7.0': 24,
-    '7.1.1': 25
+    '7.1.1': 25,
+    '8.0': 26
 
 Review comment:
   API 27 is out as well, right - which one does that correspond to? 8.1?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Need to update android_sdk.js to Support Android 8.0 
> -----------------------------------------------------
>
>                 Key: CB-13818
>                 URL: https://issues.apache.org/jira/browse/CB-13818
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-android
>    Affects Versions: cordova-android-7.0.0
>         Environment: Cordova 7.1.0
>  
>            Reporter: Zhao Bin
>            Assignee: Joe Bowser
>            Priority: Critical
>              Labels: easyfix
>             Fix For: cordova-android-7.0.0
>
>         Attachments: android_sdk.js error.png
>
>
> Currently I am working on a Cordova project and I am migrating to the new 
> Android 8.0 emulator.
> Need to update android_sdk.js to add support for Android 8.0 emulator 
> cordova-android / bin / templates / cordova / lib / android_sdk.js Line 53:
> module.exports.version_string_to_api_level = {
>     '4.0': 14,
>     '4.0.3': 15,
>     '4.1': 16,
>     '4.2': 17,
>     '4.3': 18,
>     '4.4': 19,
>     '4.4W': 20,
>     '5.0': 21,
>     '5.1': 22,
>     '6.0': 23,
>     '7.0': 24,
>     '7.1.1': 25
> };
> This causes exception in emulator.js Line 210
> {color:#5fdfff}var{color}{color:#dfdfdf} project_target 
> {color}{color:#ff1f7f}={color}{color:#dfdfdf} 
> check_reqs.{color}{color:#9fdf2f}get_target{color}{color:#dfdfdf}().{color}{color:#5fdfff}replace{color}{color:#dfdfdf}({color}{color:#dfdf7f}'android-'{color}{color:#dfdfdf},
>  {color}{color:#dfdf7f}''{color}{color:#dfdfdf});{color}
>  
> {color:#333333}I added '8.0': 26 in android_sdk.js and then it works.{color}
> {color:#333333}module.exports.version_string_to_api_level = {
>     '4.0': 14,
>     '4.0.3': 15,
>     '4.1': 16,
>     '4.2': 17,
>     '4.3': 18,
>     '4.4': 19,
>     '4.4W': 20,
>     '5.0': 21,
>     '5.1': 22,
>     '6.0': 23,
>     '7.0': 24,
>     '7.1.1': 25,{color}
> {color:#333333}    '8.0': 26 
> };{color}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to