[
https://issues.apache.org/jira/browse/CB-13834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16357672#comment-16357672
]
ASF GitHub Bot commented on CB-13834:
-------------------------------------
janpio commented on a change in pull request #248: CB-13834 TEST WIP FOR
DISCUSSION DO NOT MERGE
URL: https://github.com/apache/cordova-windows/pull/248#discussion_r167090025
##########
File path: spec/e2e/endtoend.spec.js
##########
@@ -203,7 +213,7 @@ describe('Cordova create and build', function () {
// here be 6a
- it('spec.6b should generate appxupload and appxbundle for Windows 10
project bundle release build', function () {
+ it('spec.6b should generate appxupload and appxbundle for Windows Phone
8.1 project bundle release build (all target platforms)', function () {
Review comment:
ah interesting, missed that before
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Fix tests failure with VS17 caused by CB-12499
> ----------------------------------------------
>
> Key: CB-13834
> URL: https://issues.apache.org/jira/browse/CB-13834
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-windows
> Reporter: Jan Piotrowski (Sujan)
> Priority: Major
>
> The file `Default.rd.xml` introduced by CB-12499 is unfortunately causing
> test failures on AppVeyor when Visual Studio 2017 is used to build with
> params `--release --bundle --archs="x64 x86 arm"`.
>
> {code:java}
> Started
> Creating Cordova Windows Project:
> Path: testcreate 応用
> Namespace: com.test.app
> Name: 応用
> Windows project created with cordova-windows@5.1.0-dev
> Building project: C:\projects\cordova-windows\testcreate
> 応用\CordovaApp.Windows10.jsproj
> Configuration : release
> Platform : x64
> Patching 10 in prebuild event...
> Injected base.js reference to the www/index.html
> Removing /(
> *)(<script\s+(?:type="text\/javascript"\s+)?src="\/\/Microsoft.WinJS.2.0\/js\/base.js">\s*<\/script>)(\s*)/
> from www/index.html
> Removing /(
> *)(<script\s+(?:type="text\/javascript"\s+)?src="\/\/Microsoft.Phone.WinJS.2.1\/js\/base.js">\s*<\/script>)(\s*)/
> from www/index.html
> CordovaApp.Windows10 -> C:\projects\cordova-windows\testcreate
> ??\build\windows\release\x64\win10\CordovaApp.Windows10_1.0.0.0_x64.appx
> CordovaApp.Windows10 -> C:\projects\cordova-windows\testcreate
> ??\build\windows\release\x64\win10\Upload\CordovaApp.Windows10_1.0.0.0_x64.appx
> CordovaApp.Windows10 -> C:\projects\cordova-windows\testcreate
> ??\AppPackages\CordovaApp.Windows10_1.0.0.0_Test\CordovaApp.Windows10_1.0.0.0_x64.appxbundle
> CordovaApp.Windows10 -> C:\projects\cordova-windows\testcreate
> ??\AppPackages\CordovaApp.Windows10_1.0.0.0\CordovaApp.Windows10_1.0.0.0_x64.appxbundle
> CordovaApp.Windows10 -> C:\projects\cordova-windows\testcreate
> ??\AppPackages\CordovaApp.Windows10_1.0.0.0_x64_bundle.appxupload
> Your package has been successfully created.
> Building project: C:\projects\cordova-windows\testcreate
> 応用\CordovaApp.Windows10.jsproj
> Configuration : release
> Platform : x86
> Patching 10 in prebuild event...
> C:\Program Files
> (x86)\MSBuild\Microsoft\VisualStudio\v14.0\AppxPackage\Microsoft.AppXPackage.Targets(2975,5):
> error MSB3231: Unable to remove directory
> "build\windows\bld\PackageUploadLayout\". The process cannot access the file
> 'Default.rd.xml' because it is being used by another process.
> [C:\projects\cordova-windows\testcreate ??\CordovaApp.Windows10.jsproj]
> C:\projects\cordova-windows\testcreate 応用\cordova\node_modules\q\q.js:155
> throw e;
> ^
> Error: C:\Program Files (x86)\MSBuild\14.0\bin\msbuild.exe: Command failed
> with exit code 1
> at ChildProcess.whenDone (C:\projects\cordova-windows\testcreate
> 応用\cordova\node_modules\cordova-common\src\superspawn.js:169:23)
> at emitTwo (events.js:106:13)
> at ChildProcess.emit (events.js:191:7)
> at maybeClose (internal/child_process.js:920:16)
> at Process.ChildProcess._handle.onexit
> (internal/child_process.js:230:5){code}
> Afaik this is the only test that is "touching" that file (--release and
> Windows 10), so this might be a general problem.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
