[
https://issues.apache.org/jira/browse/CB-13865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16379768#comment-16379768
]
ASF GitHub Bot commented on CB-13865:
-------------------------------------
amercode opened a new pull request #314: CB-13865: (IOS-Ipad) Making
CameraPopover for imagePicker bigger on Ipad
URL: https://github.com/apache/cordova-plugin-camera/pull/314
<!--
Please make sure the checklist boxes are all checked before submitting the
PR. The checklist
is intended as a quick reference, for complete details please see our
Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
IOS - Ipad only
### What does this PR do?
Allow the user to set the popover Width and Height on Ipads
### What testing has been done on this change?
Modified the automated test cases to accommodate for the change.
Tested the plugin on the Ipad with different popover height and width as
well as not specifying any.
### Checklist
- [x ] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [x ] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform
affected.
- [ x] Added automated test coverage as appropriate for this change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Making CameraPopover for imagePicker bigger on Ipad
> ---------------------------------------------------
>
> Key: CB-13865
> URL: https://issues.apache.org/jira/browse/CB-13865
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-plugin-camera
> Reporter: Ams
> Priority: Major
> Fix For: Master
>
>
> The popover for imagePicker from gallery is way too small and people complain
> about not being able to see images before selecting them.
>
> The fix is simple:
>
> Adding this line to willShowViewController method will set it to 960 by 960
> or as big as the screen widht/height
> [viewController setPreferredContentSize:CGSizeMake(960,960)];
> It should be added right in the if statement:
> if([navigationController isKindOfClass:[UIImagePickerController class]]){
>
> HOW CAN I COMMIT THIS CHANGE?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
