[
https://issues.apache.org/jira/browse/CB-13964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16400935#comment-16400935
]
ASF GitHub Bot commented on CB-13964:
-------------------------------------
dblotsky commented on a change in pull request #806: CB-13964: Fixed make clean
for windows
URL: https://github.com/apache/cordova-docs/pull/806#discussion_r174889719
##########
File path: Makefile
##########
@@ -154,6 +156,17 @@ JEKYLL_FLAGS =
BUILD_DATA = $(DOCS_VERSION_DATA) $(DOCS_PAGE_LIST) $(TOC_FILES)
+ifdef WINDOWS
+ VERSION_CONFIG := $(subst /,\,$(VERSION_CONFIG))
+ DEFAULTS_CONFIG := $(subst /,\,$(DEFAULTS_CONFIG))
+ DOCS_PAGE_LIST := $(subst /,\,$(DOCS_PAGE_LIST))
+ DOCS_VERSION_DATA := $(subst /,\,$(DOCS_VERSION_DATA))
+ TOC_FILES := $(subst /,\,$(TOC_FILES))
+ PLUGINS_APP := $(subst /,\,$(PLUGINS_APP))
+ CSS_DEST_DIR := $(subst /,\,$(CSS_DEST_DIR))
+ FETCHED_FILES := $(subst /,\,$(FETCHED_FILES))
+endif
Review comment:
This could break other uses of these files. Instead, change the definition
of `RM` and `RMDIR` to escape slashes, like how `makedir` does it
[here](https://github.com/apache/cordova-docs/blob/master/Makefile#L36).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> 'Make' command to build cordova website dont work in windows
> ------------------------------------------------------------
>
> Key: CB-13964
> URL: https://issues.apache.org/jira/browse/CB-13964
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-docs
> Reporter: Gandhirajan
> Priority: Critical
>
> Make commands for cordova website devleopment dont work in windows OS
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
