[
https://issues.apache.org/jira/browse/CB-13744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16464635#comment-16464635
]
ASF GitHub Bot commented on CB-13744:
-------------------------------------
dpogue closed pull request #12: CB-13744: Recognize storyboards as XML files
URL: https://github.com/apache/cordova-common/pull/12
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/src/ConfigChanges/ConfigFile.js b/src/ConfigChanges/ConfigFile.js
index ec4a28a..6f4f4c9 100644
--- a/src/ConfigChanges/ConfigFile.js
+++ b/src/ConfigChanges/ConfigFile.js
@@ -71,7 +71,7 @@ function ConfigFile_load () {
var ext = path.extname(filepath);
// Windows8 uses an appxmanifest, and wp8 will likely use
// the same in a future release
- if (ext === '.xml' || ext === '.appxmanifest') {
+ if (ext === '.xml' || ext === '.appxmanifest' || ext === '.storyboard') {
self.type = 'xml';
self.data = modules.xml_helpers.parseElementtreeSync(filepath);
} else {
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Handle storyboards as XML files
> -------------------------------
>
> Key: CB-13744
> URL: https://issues.apache.org/jira/browse/CB-13744
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-common
> Reporter: Jacques Caron
> Priority: Minor
>
> When editing a file with <config-file> or <edit-config>, only a few
> extensions are recognised as XML, the rest are considered plists.
> The CDVLaunchScreen.storyboard generated by cordova-ios is XML. To be able to
> edit it from config.xml, .storyboard files need to be recognised as XML.
> Pull request: https://github.com/apache/cordova-common/pull/12
> It may make sense to take this further, and either:
> - reverse the test, and only consider .plist files to be plists, and the rest
> XML. Not sure if that could break something
> - or add an attribute to <config-file> and <edit-config> to specify the type
> of file (XML or plist).
> However for the purposes of modifying the storyboard the (very minor) change
> in the pull request is enough.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
