[ 
https://issues.apache.org/jira/browse/CB-13770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16464645#comment-16464645
 ] 

ASF GitHub Bot commented on CB-13770:
-------------------------------------

codecov-io commented on issue #18: CB-13770: Warn when <edit-config> or 
<config-file> not found
URL: https://github.com/apache/cordova-common/pull/18#issuecomment-386783264
 
 
   # 
[Codecov](https://codecov.io/gh/apache/cordova-common/pull/18?src=pr&el=h1) 
Report
   > Merging 
[#18](https://codecov.io/gh/apache/cordova-common/pull/18?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/cordova-common/commit/6fe3256fc1cf38ac482a7ff4cf8eea935628f469?src=pr&el=desc)
 will **increase** coverage by `<.01%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/cordova-common/pull/18/graphs/tree.svg?height=150&width=650&token=jsbcYRuqT5&src=pr)](https://codecov.io/gh/apache/cordova-common/pull/18?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master      #18      +/-   ##
   ==========================================
   + Coverage   85.22%   85.23%   +<.01%     
   ==========================================
     Files          19       19              
     Lines        1767     1768       +1     
     Branches      376      376              
   ==========================================
   + Hits         1506     1507       +1     
     Misses        261      261
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/cordova-common/pull/18?src=pr&el=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[src/ConfigChanges/ConfigChanges.js](https://codecov.io/gh/apache/cordova-common/pull/18/diff?src=pr&el=tree#diff-c3JjL0NvbmZpZ0NoYW5nZXMvQ29uZmlnQ2hhbmdlcy5qcw==)
 | `94.68% <100%> (+0.02%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/cordova-common/pull/18?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/cordova-common/pull/18?src=pr&el=footer).
 Last update 
[6fe3256...a40b68c](https://codecov.io/gh/apache/cordova-common/pull/18?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Warn when target file of <config-file> or <edit-config> is not found
> --------------------------------------------------------------------
>
>                 Key: CB-13770
>                 URL: https://issues.apache.org/jira/browse/CB-13770
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: cordova-common
>            Reporter: Jacques Caron
>            Assignee: Darryl Pogue
>            Priority: Minor
>
> When one uses <config-file> or <edit-config> in config.xml or plugin.xml, 
> files that are not found are silently ignored.
> Adding a warning, and including where the file is actually looked for helps 
> when debugging such config elements.
> PR upcoming.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to