[
https://issues.apache.org/jira/browse/CB-13979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16464956#comment-16464956
]
ASF GitHub Bot commented on CB-13979:
-------------------------------------
codecov-io commented on issue #19: CB-13979: More consistency for config.xml
lookups
URL: https://github.com/apache/cordova-common/pull/19#issuecomment-386845025
#
[Codecov](https://codecov.io/gh/apache/cordova-common/pull/19?src=pr&el=h1)
Report
> Merging
[#19](https://codecov.io/gh/apache/cordova-common/pull/19?src=pr&el=desc) into
[master](https://codecov.io/gh/apache/cordova-common/commit/135e29ae9f154d2ae2238a768404c95d83c328d1?src=pr&el=desc)
will **decrease** coverage by `0.01%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/cordova-common/pull/19?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #19 +/- ##
==========================================
- Coverage 85.22% 85.21% -0.02%
==========================================
Files 19 19
Lines 1767 1765 -2
Branches 376 374 -2
==========================================
- Hits 1506 1504 -2
Misses 261 261
```
| [Impacted
Files](https://codecov.io/gh/apache/cordova-common/pull/19?src=pr&el=tree) |
Coverage Δ | |
|---|---|---|
|
[src/ConfigParser/ConfigParser.js](https://codecov.io/gh/apache/cordova-common/pull/19/diff?src=pr&el=tree#diff-c3JjL0NvbmZpZ1BhcnNlci9Db25maWdQYXJzZXIuanM=)
| `75.42% <100%> (-0.17%)` | :arrow_down: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/cordova-common/pull/19?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/cordova-common/pull/19?src=pr&el=footer).
Last update
[135e29a...ed1648c](https://codecov.io/gh/apache/cordova-common/pull/19?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> getEditConfigs() and getConfigFiles() only work for the first <platform> tag
> ----------------------------------------------------------------------------
>
> Key: CB-13979
> URL: https://issues.apache.org/jira/browse/CB-13979
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-common
> Affects Versions: Master
> Reporter: Kevin Christopher Henry
> Assignee: Darryl Pogue
> Priority: Minor
>
> I ran into something strange - my configuration would change based on the
> ordering of elements in config.xml.
> Looking at the source code, the culprit is getEditConfigs() and
> getConfigFiles() in ConfigParser.js. Unlike the rest of the code they only
> look in the first platform tag for config directives:
> {{var platform_tag = this.doc.find('./platform[@name="' + platform + '"]');}}
> {{var platform_edit_configs = platform_tag ?
> platform_tag.findall('edit-config') : [];}}
> This should probably be something like this instead (untested):
> {{var platform_edit_configs = this.doc.findall('./platform[@name="' +
> platform + '"]/edit-config');}}
> And similarly for getConfigFiles().
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
