[
https://issues.apache.org/jira/browse/CB-11691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16472969#comment-16472969
]
ASF GitHub Bot commented on CB-11691:
-------------------------------------
codecov-io commented on issue #20: CB-11691: Fix for modifying binary plists
URL: https://github.com/apache/cordova-common/pull/20#issuecomment-388537764
#
[Codecov](https://codecov.io/gh/apache/cordova-common/pull/20?src=pr&el=h1)
Report
> Merging
[#20](https://codecov.io/gh/apache/cordova-common/pull/20?src=pr&el=desc) into
[master](https://codecov.io/gh/apache/cordova-common/commit/8d6511e0d9821e4c0127564d74cca1dc533bf24c?src=pr&el=desc)
will **increase** coverage by `0.05%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/cordova-common/pull/20?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #20 +/- ##
==========================================
+ Coverage 85.23% 85.29% +0.05%
==========================================
Files 19 19
Lines 1768 1768
Branches 376 376
==========================================
+ Hits 1507 1508 +1
+ Misses 261 260 -1
```
| [Impacted
Files](https://codecov.io/gh/apache/cordova-common/pull/20?src=pr&el=tree) |
Coverage Δ | |
|---|---|---|
|
[src/ConfigChanges/ConfigFile.js](https://codecov.io/gh/apache/cordova-common/pull/20/diff?src=pr&el=tree#diff-c3JjL0NvbmZpZ0NoYW5nZXMvQ29uZmlnRmlsZS5qcw==)
| `89.85% <100%> (+0.72%)` | :arrow_up: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/cordova-common/pull/20?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/cordova-common/pull/20?src=pr&el=footer).
Last update
[8d6511e...9404fc8](https://codecov.io/gh/apache/cordova-common/pull/20?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Plugin <config-file> can't modify binary plists
> -----------------------------------------------
>
> Key: CB-11691
> URL: https://issues.apache.org/jira/browse/CB-11691
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-common
> Environment: Mac OS X version: 10.11.6
> Node version: v0.12.7
> Cordova version: 6.3.0
> Reporter: Sky Kelsey
> Priority: Major
>
> https://github.com/apache/cordova-lib/blob/master/cordova-common/src/util/plist-helpers.js#L27
> Cordova expects plists to be in XML format, and not binary. However, it fails
> to apply changes silently, masking the problem. Can you please log failures
> to modify config files, and ideally also add support for binary plists? All
> plists are generated as binary in xcode projects by default, so anyone who
> develops a plugin and needs to modify a plist is going to hit this issue.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
