[
https://issues.apache.org/jira/browse/CB-13532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16476738#comment-16476738
]
ASF GitHub Bot commented on CB-13532:
-------------------------------------
dpogue opened a new pull request #609: CB-13532: Find plugins in devDependencies
URL: https://github.com/apache/cordova-lib/pull/609
### Platforms affected
All
### What does this PR do?
Find and allow restoring plugins when they are located in package.json's
devDependencies rather than dependencies.
The same change was already made for platforms:
https://github.com/apache/cordova-lib/pull/607
### What testing has been done on this change?
Tested restoring plugins in a project with all cordova-related modules under
devDependencies.
### Checklist
- [x] [Reported an issue](https://issues.apache.org/jira/browse/CB-13532) in
the JIRA database
- [x] Commit message follows the format
- [x] Added automated test coverage as appropriate for this change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Cordova fails to find platform/plugin versions in package.json devDependencies
> ------------------------------------------------------------------------------
>
> Key: CB-13532
> URL: https://issues.apache.org/jira/browse/CB-13532
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-lib
> Reporter: Darryl Pogue
> Assignee: Audrey So
> Priority: Major
> Labels: tools-next
>
> Cordova only looks at the {{dependencies}} section of package.json, and
> ignores anything specified in {{devDependencies}}. This results in the
> default pinned versions for platforms/plugins being used.
> Code in question:
> https://github.com/apache/cordova-lib/blob/da8ebf6cb81dd84c22e24fdf0baff9837a544b2d/src/cordova/platform/addHelper.js#L109-L113
> This is wrong because Cordova (and its related bits) is not a dependency of
> my application code, it is a build tool that belongs in devDependencies.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
