[
https://issues.apache.org/jira/browse/CB-12397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16494626#comment-16494626
]
ASF GitHub Bot commented on CB-12397:
-------------------------------------
brodybits commented on issue #69: [CB-12397] .gitignore instead of unwanted
.npmignore after cordova create (7.0.1)
URL: https://github.com/apache/cordova-discuss/issues/69#issuecomment-393018400
@raphinesse I just raised raphinesse/cordova-create#1 on your fork with a
major rework of apache/cordova-create#8 to work on master, with better test
refactoring, as you had requested. It is marked with a TODO to use fs-extra
instead of shelljs once apache/cordova-create#14 lands. Finishing a long day
now, can take another look when I start again. I would be happy to continue in
one of the following directions:
I can rework to use fs-extra once apache/cordova-create#14 lands and maybe
fix to use `_gitignore` instead of `.npmignore`
Preferred: Hand it over to you to finish up as needed to resolve this issue
(you should probably raise a new PR and we close apache/cordova-create#8).
If you take it over I would highly suggest you add `Co-authored-by:` lines
for both of us, like I did in apache/cordova-create#14, just in case the
changes are landed with incorrect author (I have seen the cases of this
happening in other projects).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> fix .gitignore for plugins & platforms in app template
> ------------------------------------------------------
>
> Key: CB-12397
> URL: https://issues.apache.org/jira/browse/CB-12397
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-app-hello-world, cordova-cli, cordova-create,
> cordova-lib
> Reporter: Chris Brody
> Priority: Major
> Labels: backlog, easy-fix
>
> Followup to CB-12008 (autosave by default in cordova@7): if a user creates an
> app using "cordova create" there should be a .gitignore file to exclude the
> plugins and platforms artifacts from git.
> I raise this since I have seen way too many apps with outdated plugins /
> platforms artifacts included in git.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
