[ 
https://issues.apache.org/jira/browse/CB-13979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16496062#comment-16496062
 ] 

ASF subversion and git services commented on CB-13979:
------------------------------------------------------

Commit c700a5d6830fe7401551c4b4ce65c1cccbb85f17 in cordova-common's branch 
refs/heads/2.2.x from [~dpogue]
[ https://gitbox.apache.org/repos/asf?p=cordova-common.git;h=c700a5d ]

CB-13979: More consistency for config.xml lookups


> getEditConfigs() and getConfigFiles() only work for the first <platform> tag
> ----------------------------------------------------------------------------
>
>                 Key: CB-13979
>                 URL: https://issues.apache.org/jira/browse/CB-13979
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-common
>    Affects Versions: Master
>            Reporter: Kevin Christopher Henry
>            Assignee: Darryl Pogue
>            Priority: Minor
>              Labels: pull-request-available
>
> I ran into something strange - my configuration would change based on the 
> ordering of elements in config.xml.
> Looking at the source code, the culprit is getEditConfigs() and 
> getConfigFiles() in ConfigParser.js. Unlike the rest of the code they only 
> look in the first platform tag for config directives:
> {{var platform_tag = this.doc.find('./platform[@name="' + platform + '"]');}}
> {{var platform_edit_configs = platform_tag ? 
> platform_tag.findall('edit-config') : [];}}
> This should probably be something like this instead (untested):
> {{var platform_edit_configs = this.doc.findall('./platform[@name="' + 
> platform + '"]/edit-config');}}
> And similarly for getConfigFiles().



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to