[
https://issues.apache.org/jira/browse/CB-13767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16517582#comment-16517582
]
Raphael edited comment on CB-13767 at 6/19/18 10:07 PM:
--------------------------------------------------------
{quote}I think it would help to know what cordova-fetch does [...] and why the
performance is affected
{quote}
I'd like to think I answered the first question in my last comment. If it's
still unclear, feel free to take a look at the code. It's not too much and
quite readable by now. The performance is affected because cordova-fetch is
called by cordova-lib.
{quote}why it’s necessary, [...] how installation was done before.
{quote}
I cannot answer this properly – maybe someone else can. I only know that
platforms and plugins had to bundle their node_modules folders or manage
dependency installation themselves to work properly before Cordova 8. Ever
worked with a repository where node_modules is under version control? I assure
you, it's not pretty.
was (Author: raphinesse):
{quote}I think it would help to know what cordova-fetch does [...] and why the
performance is affected
{quote}
I'd like to think I answered the first question in my last comment. If it's
still unclear, feel free to take a look at the code. It's not too much and
quite readable by now. The performance is affected because it's called by
cordova-lib.
{quote}why it’s necessary, [...] how installation was done before.
{quote}
I cannot answer this properly – maybe someone else can. I only know that
platforms and plugins had to bundle their node_modules folders or manage
dependency installation themselves to work properly before Cordova 8. Ever
worked with a repository where node_modules is under version control? I assure
you, it's not pretty.
> Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch
> -------------------------------------------------------------------------
>
> Key: CB-13767
> URL: https://issues.apache.org/jira/browse/CB-13767
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-lib
> Reporter: Andrew Crites
> Priority: Major
>
> This is for a project with a wide variety of plugins ... about 25. This may
> be above average, but not extreme. I've updated the project from cordova 6.5
> to cordova 8. Cordova 8 always uses {{cordova-fetch}} to install plugins, so
> I can't opt out. Before, I was not using {{cordova-fetch}}.
> {code}
> $ time npx cordova@6.5 platform add ios
> 23.85s user 9.26s system 130% cpu 25.414 total
> $ time npx cordova@8 platform add ios --nosave
> 402.44s user 61.94s system 119% cpu 6:28.09 total
> {code}
> That takes over 15 times longer. {{--nosave}} was used since this is the
> default behavior for 6.5.
> For subsequent installations using {{--save}} (or default) the performance is
> still like this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
