[ https://issues.apache.org/jira/browse/CB-14145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16517610#comment-16517610 ]
ASF GitHub Bot commented on CB-14145: ------------------------------------- brodybits opened a new pull request #173: CB-14145: package.json updates to resolve npm audit warnings URL: https://github.com/apache/cordova-coho/pull/173 <!-- Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines: http://cordova.apache.org/contribute/contribute_guidelines.html Thanks! --> ### Platforms affected All ### What does this PR do? - tests working again - package.json updates to resolve npm audit warnings ### What testing has been done on this change? - `npm test` passes in my local workares - fixes originally part of #172 (1.0.1 update) pass on AppVeyor CI & Travis CI ### Checklist - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected. - [x] Added automated test coverage as appropriate for this change. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Resolve npm audit issues > ------------------------ > > Key: CB-14145 > URL: https://issues.apache.org/jira/browse/CB-14145 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-android, cordova-app-hello-world, > cordova-browser, cordova-cli, cordova-coho, cordova-common, cordova-fetch, > cordova-ios, cordova-js, cordova-lib, cordova-osx, cordova-windows > Reporter: Chris Brody > Assignee: Chris Brody > Priority: Major > > From private discussions I discovered that running {{npm audit}} on a number > of components would report dependencies with security issues. While we could > not see any {{npm audit}} issues that may affect applications built using > Cordova I think it is extremely important to resolve these issues as soon as > possible. Most affect devDependencies used for testing of Cordova itself; a > minority seem to affect Cordova scripts that may be run by Cordova > application developers. Better safe than sorry! > I would like to resolve this issue as follows: > * patch release of common library components such as {{cordova-common}}, > {{cordova-lib}}, etc. (fixed in minor release branch) > * patch or minor release of other affected components such as CLI, Cordova > platform implementations, major plugins, etc. (expected to be fixed in minor > release branch; do not want to pollute the master branch with extra reverts, > updated node_modules committed, etc.) > * {{npm audit}} issues resolved in master branch for next major release, > which should NOT be shipped with any {{npm audit}} issues lurking > * {{npm audit}} step added to CI for both patch release and next major release -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org