[
https://issues.apache.org/jira/browse/CB-14173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16526489#comment-16526489
]
ASF subversion and git services commented on CB-14173:
------------------------------------------------------
Commit f17ccf70448a4822ba2ed0434dd39b905822321a in cordova-fetch's branch
refs/heads/master from Raphael von der Grün
[ https://gitbox.apache.org/repos/asf?p=cordova-fetch.git;h=f17ccf7 ]
CB-14173 Fix cordova <platform|plugin> add --link (#26)
This drops support for the untested and undocumented `link` option
which when set, caused `npm link` to be run instead of `npm install`.
However, the installed package's name cannot be extracted from the
output of `npm link`. Thus we failed in that case.
Now we always run `npm install` instead. This works for the use case of
`cordova <platform|plugin> add --link` since packages identified by a
local path are installed as symbolic links by npm.
> cordova-fetch nightly breaks with --link
> ----------------------------------------
>
> Key: CB-14173
> URL: https://issues.apache.org/jira/browse/CB-14173
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-fetch
> Reporter: Darryl Pogue
> Assignee: Raphael
> Priority: Major
>
> A coworker just ran this:
> {code:java}
> npx cordova platform add --link ../cordova-ios/{code}
> It failed with this error:
> {noformat}
> Warning: using prerelease version 8.0.1-nightly.2018.6.26.77b7324f
> (cordova-lib@8.0.1-nightly.2018.6.26.da4b4b37)
> { CordovaError: Could not determine package name from output:
> up to date in 6.878s
> [!] 3 vulnerabilities found [2885 packages audited]
> Severity: 3 low
> Run `npm audit` for more detail/usr/local/lib/node_modules/cordova-ios ->
> /Projects/cordova-ios
> /Projects/launch-cordova-test/node_modules/cordova-ios ->
> /usr/local/lib/node_modules/cordova-ios -> /Projects/cordova-ios
> at getTargetPackageSpecFromNpmInstallOutput
> (/Projects/launch-cordova-test/node_modules/cordova-fetch/index.js:97:15)
> at _fulfilled (/Projects/launch-cordova-test/node_modules/q/q.js:854:54)
> at /Projects/launch-cordova-test/node_modules/q/q.js:883:30
> at Promise.promise.promiseDispatch
> (/Projects/launch-cordova-test/node_modules/q/q.js:816:13)
> at /Projects/launch-cordova-test/node_modules/q/q.js:624:44
> at runSingle (/Projects/launch-cordova-test/node_modules/q/q.js:137:13)
> at flush (/Projects/launch-cordova-test/node_modules/q/q.js:125:13)
> at process._tickCallback (internal/process/next_tick.js:172:11)
> name: 'CordovaError',
> message: 'Could not determine package name from output:\nup to date in
> 6.878s\n[!] 3 vulnerabilities found [2885 packages audited]\n Severity: 3
> low\n Run `npm audit` for more
> detail\n\n/usr/local/lib/node_modules/cordova-ios ->
> /Projects/cordova-ios\n/Projects/launch-cordova-test/node_modules/cordova-ios
> -> /usr/local/lib/node_modules/cordova-ios -> /Projects/cordova-ios',
> code: 0,
> context: undefined }{noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
