[
https://issues.apache.org/jira/browse/CB-14166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16546652#comment-16546652
]
ASF GitHub Bot commented on CB-14166:
-------------------------------------
oliversalzburg commented on issue #622: CB-14166: (cli) Fixed issue when
installing plugins on windows
URL: https://github.com/apache/cordova-lib/pull/622#issuecomment-405593375
https://github.com/moxystudio/node-cross-spawn/blob/master/lib/util/escape.js
might be of interest here. Ultimately however, I would recommend just moving to
https://github.com/sindresorhus/execa or any other library that gets it right.
IMHO, this is not to be solved here, but in cordova-fetch, which is what
shells out and which is what should be adjusted generically, not for this
detail specifically.
I quickly dropped execa into the project to try it out and it looks
promising. However, there are still failures in this test suite, but I claim
that those tests might be broken. Test#015 asserts that when installing
**cordova-plugin-camera@^2.3.0** that **cordova-plugin-camera@^2.4.1** would be
added to the `package.json`. I don't think that is correct, because when I
explicitly request `^2.3.0`, then *that* should be persisted to `package.json`,
shouldn't it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Cordova on windows fails when adding plugin
> -------------------------------------------
>
> Key: CB-14166
> URL: https://issues.apache.org/jira/browse/CB-14166
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-windows
> Reporter: takuya
> Assignee: Jesse MacFadyen
> Priority: Blocker
>
> cordova on windows fails to add the plugin.
> This error happens even when cordova-plugin-whitelist.
> Therefore `cordova platform add windows` also fails.
> For example,
> ```
> > cordova create sample
> > cd sample
> > cordova platform add windows
> ```
> brings following error.
> ```
> ...
> Check your connection and plugin name/version/URL.
> Error: C:\Program Files (x86)\Nodist\bin\npm.exe: Command failed with exit
> code 1 Error output:
> npm ERR! code EINVALIDTAGNAME
> npm ERR! Invalid tag name ""1"": Tags may not have any characters that
> encodeURIComponent encodes.
> ```
> This error happens for windows environment only.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
