[
https://issues.apache.org/jira/browse/CB-14075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16576551#comment-16576551
]
ASF GitHub Bot commented on CB-14075:
-------------------------------------
janpio closed pull request #289: CB-14075: (windows) Remove Node 4 from CI -
cordova-windows
URL: https://github.com/apache/cordova-windows/pull/289
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/.travis.yml b/.travis.yml
index 119ba5eb..7e44fef2 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -1,15 +1,21 @@
language: node_js
sudo: false
+
git:
depth: 10
+
node_js:
- - "4"
- "6"
+ - "8"
+ - "10"
+
install:
- - npm install
- - npm install -g codecov
+ - npm install
+ - npm install -g codecov
+
script:
- - npm run eslint
- - npm run cover
+ - npm run eslint
+ - npm run cover
+
after_script:
- - codecov
+ - codecov
diff --git a/appveyor.yml b/appveyor.yml
index 3eb61947..94a8d4c0 100644
--- a/appveyor.yml
+++ b/appveyor.yml
@@ -31,12 +31,6 @@ environment:
- nodejs_version: "6"
APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2015
- - nodejs_version: "4"
- APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2017
-
- - nodejs_version: "4"
- APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2015
-
matrix:
allow_failures:
- APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2017
diff --git a/package.json b/package.json
index 42d87689..eb3c9aac 100644
--- a/package.json
+++ b/package.json
@@ -45,6 +45,10 @@
"jasmine": "^2.99.0",
"rewire": "^2.5.1"
},
+ "engines": {
+ "node": ">=6.0.0"
+ },
+ "engineStrict": true,
"bundledDependencies": [
"cordova-common",
"elementtree",
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Remove Node 4 from CI - cordova-windows
> ---------------------------------------
>
> Key: CB-14075
> URL: https://issues.apache.org/jira/browse/CB-14075
> Project: Apache Cordova
> Issue Type: Sub-task
> Components: cordova-windows
> Reporter: Darryl Pogue
> Assignee: Darryl Pogue
> Priority: Minor
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
