[
https://issues.apache.org/jira/browse/CB-14228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16578014#comment-16578014
]
Bryan Ellis edited comment on CB-14228 at 8/13/18 9:34 AM:
-----------------------------------------------------------
[~brodybits] I am not sure where to bring up this issue. I noticed the VOTE
thread and the thread had nothing about where to bring up a discussion
point/concern.
In the vote, I noticed that the `cordova-common` dep is still on 2.x.
In `cordova-common` 2.x there was a bug reported which I committed a PR and fix
for, but, it is only in 3.0.0-dev. Should this fix be cherry-picked and release
in 2.x of common and then bump OSX platform to that version?
*The gist of the issue*
When you add a plugin and build the first time, it will trigger the device
ready. This is expected. But if you build a second or third or any thereafter,
the device is ready is not triggered.
https://issues.apache.org/jira/browse/CB-14099
https://github.com/apache/cordova-common/pull/32
Please note, even though the PR says closed, the fix was merged into master...
It seems the person used coho to merge my changes and it closed my PR instead.
was (Author: erisu):
[~brodybits] I am not sure where to bring up this issue. I noticed the VOTE
thread and the thread had nothing about where to discuss.
In the vote, I noticed that the `cordova-common` dep is still on 2.x.
In `cordova-common` 2.x there was a bug reported which I committed a PR and fix
for, but, it is only in 3.0.0-dev. Should this fix be cherry-picked and release
in 2.x of common and then bump OSX platform to that version?
*The gist of the issue*
When you add a plugin and build the first time, it will trigger the device
ready. This is expected. But if you build a second or third or any thereafter,
the device is ready is not triggered.
https://issues.apache.org/jira/browse/CB-14099
https://github.com/apache/cordova-common/pull/32
Please note, even though the PR says closed, the fix was merged into master...
It seems the person used coho to merge my changes and it closed my PR instead.
> cordova-osx patch release July 2018
> -----------------------------------
>
> Key: CB-14228
> URL: https://issues.apache.org/jira/browse/CB-14228
> Project: Apache Cordova
> Issue Type: Task
> Components: cordova-osx
> Reporter: Chris Brody
> Assignee: Chris Brody
> Priority: Major
>
> Patch release of cordova-osx package with CB-14145 (npm audit issues)
> resolved.
> Following steps at
> https://github.com/apache/cordova-coho/blob/master/docs/platforms-release-process.md
> (with some modifications)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
