[ 
https://issues.apache.org/jira/browse/CB-14166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16786445#comment-16786445
 ] 

ASF subversion and git services commented on CB-14166:
------------------------------------------------------

Commit d4df8a9390f92fa28ba7307f8ca5bbb2f9041b82 in cordova-lib's branch 
refs/heads/master from Almir Kadric
[ https://gitbox.apache.org/repos/asf?p=cordova-lib.git;h=d4df8a9 ]

CB-14166: (cli) Fixed issue when install plugins on windows (#622)

The npm package name is already wrapped in quotes to prevent special characters 
from being execute. However the additional win32 code was further injecting 
quotes around the version causing npm to return a EINVALIDTAGNAME error. The 
win32 code is redundant and seems to not be required.

> Cordova on windows fails when adding plugin
> -------------------------------------------
>
>                 Key: CB-14166
>                 URL: https://issues.apache.org/jira/browse/CB-14166
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-windows
>            Reporter: takuya
>            Assignee: Jesse MacFadyen
>            Priority: Blocker
>         Attachments: screenshot-1.png, スクリーンショット 2018-09-06 11.36.42.png
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> cordova on windows fails to add the plugin.
> This error happens even when cordova-plugin-whitelist.
> Therefore `cordova platform add windows` also fails.
> For example,
> ```
> > cordova create sample
> > cd sample
> > cordova platform add windows
> ```
> brings following error.
> ```
> ...
> Check your connection and plugin name/version/URL.
> Error: C:\Program Files (x86)\Nodist\bin\npm.exe: Command failed with exit 
> code 1 Error output:
> npm ERR! code EINVALIDTAGNAME
> npm ERR! Invalid tag name ""1"": Tags may not have any characters that 
> encodeURIComponent encodes.
> ```
> This error happens for windows environment only.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to