brodybits opened a new pull request #987: URL: https://github.com/apache/cordova-android/pull/987
<!-- Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines: http://cordova.apache.org/contribute/contribute_guidelines.html Thanks! --> ### Platforms affected Android ### Motivation and Context <!-- Why is this change required? What problem does it solve? --> <!-- If it fixes an open issue, please link to the issue here. --> see #986 - I think this is needed to avoid crash with JSON memory issue in case of a large number of moderately-sized plugin response messages I hope we can consider this change for cordova-android 9.0.0 which should be coming in the near future. ### Description <!-- Describe your changes in detail --> As I proposed in issue #986, this proposal reduces the internal `MAX_PAYLOAD_SIZE` constant from 500 MB to 16 MB. ### Testing <!-- Please describe in detail how you tested your changes. --> I tested with [`github:brodybits/cordova-big-android-response-payload-test`](https://github.com/brodybits/cordova-big-android-response-payload-test), with `NATIVE_RESPONSE_COUNT` changed from 20 to 400, as discussed in issue #986. ### Remaining quirks As I said in #986: - missing module warning message issue is uncovered, see #986 for more details - without background threading, not all response messages make it to the JavaScript side I hope someone will have time to get to the bottom of these remaining quirks, someday. ### Checklist - [x] I've run the tests to see all new and existing tests pass - ~~I added automated test coverage as appropriate for this change~~ - ~~Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)~~ - ~~If this Pull Request resolves an issue,~~ I linked to the issue in the text above ~~(and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))~~ - ~~I've updated the documentation if necessary~~ ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
