[ 
https://issues.apache.org/jira/browse/CXF-4469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13434145#comment-13434145
 ] 

Aki Yoshida commented on CXF-4469:
----------------------------------

Hi Colm,
as discussed on #cxf, I simply moved the parseRolesInAssertion methods to an 
internal utility class and added a method that takes the assertion wrapper and 
returns the list of roles in this class.

alternatively, we could have added another method getAssertion(Object 
assertionWrapper) in the utility class to get the assertion first and then call 
the parseRolesInAssertion(Object assertion, ...). In that case, we could have 
kept the replacement for those protected methods by adding protected 
parseRolesInAssertion(Object assertion, ...) in WSS4JInInterceptor that calls 
this utility method.

thanks.
regards, aki

                
> 2.6.x rt-ws-security bundle is requiring opensaml
> -------------------------------------------------
>
>                 Key: CXF-4469
>                 URL: https://issues.apache.org/jira/browse/CXF-4469
>             Project: CXF
>          Issue Type: Bug
>          Components: WS-* Components
>    Affects Versions: 2.6.1
>            Reporter: Aki Yoshida
>            Assignee: Aki Yoshida
>             Fix For: 2.6.2
>
>
> The CXF's 2.6.x's rt-ws-security bundle is requiring opensaml, although 
> opensaml is supposed to be optional.
> The cxf all bundle declares opensaml* as optional and not requiring them.
> The rt-ws-security's pom also needs this optional import declaration.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to