[ 
https://issues.apache.org/jira/browse/CXF-6729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15093762#comment-15093762
 ] 

Neal Hu commented on CXF-6729:
------------------------------

Hi Sergey, thanks for your review and comments.

1. I will update the code to keep v1 cookie only. Have the flag in the 
convertV0SetCookie(cookie, false); used to be compatible with RFC1123Date.
2. Done
3. Do you mean the value field of the cookie or the cookie instance? 
4. Done
5. OK
6. I have updated the NewCookie.fromString() to unquote the values and added 
the test case. Do we need update CookieHeaderProvider also? RI parse the string 
to cookie as below:
https://github.com/jersey/jersey/blob/master/core-common/src/main/java/org/glassfish/jersey/message/internal/CookiesParser.java
 if (value.startsWith("\"") && value.endsWith("\"") && value.length() > 1) {
                value = value.substring(1, value.length() - 1);
            }

Thanks, 
Neal

>  Version 1 NewCookie is not compliant with RFC 2109
> ---------------------------------------------------
>
>                 Key: CXF-6729
>                 URL: https://issues.apache.org/jira/browse/CXF-6729
>             Project: CXF
>          Issue Type: Bug
>          Components: JAX-RS
>    Affects Versions: 3.0.7, 3.1.4
>         Environment: Windows
>            Reporter: Neal Hu
>             Fix For: 3.1.5, 3.0.8
>
>         Attachments: NewCookieHeaderProvider.java, 
> NewCookieHeaderProviderTest.java, ResponseImplTest.java
>
>
> Hi,
> From http://www.ietf.org/rfc/rfc2109.txt and 
> http://stackoverflow.com/questions/572482/why-do-cookie-values-with-whitespace-arrive-at-the-client-side-with-quotes
> the version 1 cookie look like: name="value with 
> spaces";Max-Age=3600;Path="/";Version=1
> NewCookieHeaderProvider.toString(NewCookie) has not handled the special 
> characters(RFC2068) that need around with quotes



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to