[
https://issues.apache.org/jira/browse/CXF-6759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15123312#comment-15123312
]
Sergey Beryozkin commented on CXF-6759:
---------------------------------------
I've applied you patch with minor modifications,
I pushed the counter check closer to the point where the method name is added
because we also remove there few extra characters in the name (ex, '-' for
now). I also updated the counter logic a bit, if we have a 2nd occurrence of
the same name then we'd have for ex echo2 as opposed to echo1, etc. Also
updated the test.
Thanks for your patch.
You can see the checkstyle can be disabled with the OFF/ON comments, though the
code will need to be optimized, 9 parameters are passed, so at some later stage
I can introduce a MethodContext bean instead...
Sergey
> WADL2JAVA Tools Generated Source has Duplicate Method Name
> ----------------------------------------------------------
>
> Key: CXF-6759
> URL: https://issues.apache.org/jira/browse/CXF-6759
> Project: CXF
> Issue Type: Bug
> Components: JAX-RS, Tooling
> Affects Versions: 3.0.7, 3.1.4
> Environment: Windows
> Reporter: Neal Hu
> Fix For: 3.1.5, 3.0.8, 3.2.0
>
> Attachments: SourceGenerator.patch
>
>
> Generate source using below wadl file contains duplicate method name:
> command: wadl2java.bat -p cxf -d . -impl hello.wadl
> <application xmlns="http://wadl.dev.java.net/2009/02";
> xmlns:xs="http://www.w3.org/2001/XMLSchema";>
> <grammars/>
> <resources base="http://localhost:9088/Pojo/hello/";>
> <resource path="/BasicResource">
> <resource path="/echo">
> <method name="GET">
> <response>
> <representation mediaType="application/json">
> <param name="result" style="plain" type="xs:string"/>
> </representation>
> </response>
> </method>
> <method name="GET">
> <response>
> <representation mediaType="text/plain">
> <param name="result" style="plain" type="xs:string"/>
> </representation>
> </response>
> </method>
> </resource>
> </resource>
> </resources>
> </application>
> /**
> * Created by Apache CXF WadlToJava code generator
> **/
> package cxf;
> import javax.ws.rs.GET;
> import javax.ws.rs.Path;
> import javax.ws.rs.Produces;
> @Path("/BasicResource")
> public class BasicResourceResource {
> @GET
> @Produces("application/json")
> @Path("/echo")
> public String getEcho() {
> //TODO: implement
> return null;
> }
> @GET
> @Produces("text/plain")
> @Path("/echo")
> public String getEcho() {
> //TODO: implement
> return null;
> }
> }
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
