[ https://issues.apache.org/jira/browse/CXF-7462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16111011#comment-16111011 ]
ASF GitHub Bot commented on CXF-7462: ------------------------------------- Github user andymc12 commented on a diff in the pull request: https://github.com/apache/cxf/pull/301#discussion_r130893603 --- Diff: rt/rs/sse/src/main/java/org/apache/cxf/jaxrs/sse/OutboundSseEventImpl.java --- @@ -24,24 +24,24 @@ import javax.ws.rs.core.MediaType; import javax.ws.rs.sse.OutboundSseEvent; -public class OutboundSseEventImpl implements OutboundSseEvent { - private String id; - private String name; - private String comment; - private long reconnectDelay = -1; - private Class<?> type; - private Type genericType; - private MediaType mediaType; - private Object data; +public final class OutboundSseEventImpl implements OutboundSseEvent { + private final String id; + private final String name; + private final String comment; + private final long reconnectDelay; + private final Class<?> type; + private final Type genericType; + private final MediaType mediaType; + private final Object data; public static class BuilderImpl implements Builder { private String id; private String name; private String comment; private long reconnectDelay = -1; - private Class<?> type; + private Class<?> type = String.class; --- End diff -- Hmm... I must've been looking at an older version of the javadoc. It looks like there is no `data(String s)` method - it was changed to `data(Object o)`. I'll change the code to use the type of the passed-in object if the class is not specified by the user. Thanks again. > OutboundSseEventImpl could use some minor tweaks > ------------------------------------------------ > > Key: CXF-7462 > URL: https://issues.apache.org/jira/browse/CXF-7462 > Project: CXF > Issue Type: Improvement > Components: JAX-RS > Affects Versions: 3.2.0 > Reporter: Andy McCright > Priority: Minor > Fix For: 3.2.0 > > > The OutboundSseEventImpl class could use some minor tweaks, including: > 1) Make the fields final to reflect that the event is immutable. > 2) Use defaults for the data type (String.class) and media type > (SERVER_SENT_EVENT_TYPE). > 3) Restrict the constructor's visibility. > I also plan to add some tests for these changes. -- This message was sent by Atlassian JIRA (v6.4.14#64029)