[ 
https://issues.apache.org/jira/browse/CXF-7571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16301682#comment-16301682
 ] 

ASF GitHub Bot commented on CXF-7571:
-------------------------------------

reta commented on a change in pull request #351: [CXF-7571] Adding support for 
CDI injection of @Context objects.
URL: https://github.com/apache/cxf/pull/351#discussion_r158527866
 
 

 ##########
 File path: 
systests/cdi/base/src/main/java/org/apache/cxf/systests/cdi/base/OpenTracingProducer.java
 ##########
 @@ -0,0 +1,32 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.cxf.systests.cdi.base;
+
+import javax.enterprise.context.ApplicationScoped;
+import javax.enterprise.inject.Produces;
+import org.apache.cxf.tracing.opentracing.jaxrs.OpenTracingFeature;
+
+@ApplicationScoped
+public class OpenTracingProducer {
 
 Review comment:
   Adding `bean.xml` to `opentracing` module fixed the issue right away, the 
`OpenTracingFeature` has been discovered. As a side note, could you please move 
these testcases to `systest-tracing` project, it would be good to keep the CDI 
tests clean from external integration. Thank you.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


>  Revamp of the CXF injection implementation
> -------------------------------------------
>
>                 Key: CXF-7571
>                 URL: https://issues.apache.org/jira/browse/CXF-7571
>             Project: CXF
>          Issue Type: Improvement
>            Reporter: Andriy Redko
>            Assignee: John D. Ament
>
> As more deep integration with CDI revealed, there are complexities in 
> bringing together {{@Context}}- and {{@Inject}}-based injections. 
> Encapsulating CXF injection implementation and than delegating the hard work 
> to appropriate strategy (CDI, Spring, ...) would be the right solution to 
> address the problem at its roots.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to