[ https://issues.apache.org/jira/browse/CXF-7600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16493551#comment-16493551 ]
ASF GitHub Bot commented on CXF-7600: ------------------------------------- rmannibucau commented on a change in pull request #420: CXF-7600: Add Automatic-Module-Name MANIFEST entry for Java 9 compatibility URL: https://github.com/apache/cxf/pull/420#discussion_r191433130 ########## File path: maven-plugins/wsdl-validator-plugin/pom.xml ########## @@ -29,6 +29,9 @@ <artifactId>cxf-maven-plugins</artifactId> <version>3.2.5-SNAPSHOT</version> </parent> + <properties> + <cxf.module.name>org.apache.cxf.plugin.wsdl-validator</cxf.module.name> Review comment: It is allowed - compared to underscores or leading numbers which are not supported - but not very well integrated AFAIK in the ecosystem so avoiding it is not bad. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add Automatic-Module-Name MANIFEST entry for Java 9 compatibility > ----------------------------------------------------------------- > > Key: CXF-7600 > URL: https://issues.apache.org/jira/browse/CXF-7600 > Project: CXF > Issue Type: Improvement > Components: Build system > Affects Versions: 3.2.1 > Reporter: Dennis Kieselhorst > Assignee: Andriy Redko > Priority: Major > > See mailinglist discussion: > https://lists.apache.org/thread.html/790a276b4a7b3d977f5cb1abdc764a0529324b286fba915d19352afb@%3Cdev.cxf.apache.org%3E > Similar issues: IO-551, LANG-1338, CODEC-242 -- This message was sent by Atlassian JIRA (v7.6.3#76005)