[ 
https://issues.apache.org/jira/browse/CXF-7741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16505790#comment-16505790
 ] 

Freeman Fang edited comment on CXF-7741 at 6/8/18 7:26 AM:
-----------------------------------------------------------

A quick update of this issue.

Just appended a patch.

Since JDK11, those modules are removed from the JDK.
{code:java}
* java.corba — CORBA
 * java.transaction — The subset of the Java Transaction API defined by Java SE 
to support CORBA Object Transaction Services
 * java.activation — JavaBeans Activation Framework
 * java.xml.bind — Java Architecture for XML Binding (JAXB)
 * java.xml.ws — Java API for XML Web Services (JAX-WS), Web Services Metadata 
for the Java Platform, and SOAP with Attachments for Java (SAAJ)
 * java.xml.ws.annotation — The subset of the JSR-250 Common Annotations 
defined by Java SE to support web services
{code}
 

So we need to explicitly use external libs as maven dependencies. This actually 
can make our life much easier. Since now those dependencies are on the 
classpath, they are also in the unnamed module, so they are accessible for CXF 
framework, which means we can get rid of the most add-exports, add-opens, 
add-modules, patch-module stuff when we launch the JVM.

 

The only major issue left is that I didn't figure out the external counterpart 
of java.corba moudle in JDK, though I tried a couple of combination such as 
org.glassfish.corba and com.sun.corba, but none of them can work with the Corba 
binding in CXF. I am wondering are we still going to support Corba with JDK11, 
considering  Corba is  quite old and I suppose we needn't to worry about it.

 

Btw, I will hold the commit until all necessary upstream project which can 
support jdk11 get released(Karaf, Aries Proxy, PAX Exam, etc)

Freeman


was (Author: ffang):
A quick update of this issue.

Just appended a patch.

Since JDK11, those modules are removed from the JDK.

{code}
* java.corba — CORBA
 * java.transaction — The subset of the Java Transaction API defined by Java SE 
to support CORBA Object Transaction Services
 * java.activation — JavaBeans Activation Framework
 * java.xml.bind — Java Architecture for XML Binding (JAXB)
 * java.xml.ws — Java API for XML Web Services (JAX-WS), Web Services Metadata 
for the Java Platform, and SOAP with Attachments for Java (SAAJ)
 * java.xml.ws.annotation — The subset of the JSR-250 Common Annotations 
defined by Java SE to support web services
{code}

 

So we need to explicitly use external libs as maven dependencies. This actually 
can make our life much easier. Since now those dependencies are on the 
classpath, they are also in the unnamed module, so they are accessible for CXF 
framework, which means we can get rid of the most add-exports, add-opens, 
add-modules, patch-module stuff when we launch the JVM.

 

The only major issue left is that I didn't figure out the external counterpart 
of java.corba moudle in JDK, though I tried a couple of combination such as 
org.glassfish.corba and com.sun.corba, but none of them can work with the Corba 
binding in CXF. I am wondering are we still going to support Corba with JDK11, 
considering  Corba is  quite old and I suppose we needn't to worry about it.

 

Freeman

> ensure we can build CXF with JDK11
> ----------------------------------
>
>                 Key: CXF-7741
>                 URL: https://issues.apache.org/jira/browse/CXF-7741
>             Project: CXF
>          Issue Type: Task
>            Reporter: Freeman Fang
>            Assignee: Freeman Fang
>            Priority: Major
>         Attachments: CXF-7741.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to