Adrian Cole created CXF-7844: -------------------------------- Summary: Change Zipkin/Brave XML to use brave-spring-beans Key: CXF-7844 URL: https://issues.apache.org/jira/browse/CXF-7844 Project: CXF Issue Type: Improvement Components: Tracing Brave Reporter: Adrian Cole
I noticed the sample projects don't connect to any server. This could make it hard for someone to get started. Also, the XML beans don't use the helpers that exist in brave. https://github.com/apache/cxf/tree/master/distribution/src/main/release/samples/jax_rs/tracing_brave https://github.com/apache/cxf/tree/master/distribution/src/main/release/samples/jax_rs/tracing_brave_osgi https://github.com/apache/cxf/tree/master/distribution/src/main/release/samples/jaxws_tracing_brave_osgi Could these be changed to use brave-spring-beans? or otherwise make a functional tracer? https://github.com/openzipkin/brave/tree/master/spring-beans Here are some example configurations: https://github.com/openzipkin/brave-webmvc-example/blob/master/webmvc3/src/main/webapp/WEB-INF/applicationContext.xml https://github.com/openzipkin/brave-webmvc-example/blob/master/webmvc4-boot/src/main/java/brave/webmvc/TracingConfiguration.java -- This message was sent by Atlassian JIRA (v7.6.3#76005)