[
https://issues.apache.org/jira/browse/CXF-7867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16646154#comment-16646154
]
ASF GitHub Bot commented on CXF-7867:
-------------------------------------
coheigea commented on a change in pull request #456: CXF-7867 - Allow the
AbstractSpnegoAuthSupplier loginConfig to be used
URL: https://github.com/apache/cxf/pull/456#discussion_r224366969
##########
File path:
services/sts/systests/advanced/src/test/java/org/apache/cxf/systest/sts/kerberos/KerberosDelegationTokenTest.java
##########
@@ -135,6 +138,48 @@ public void testKerberosTokenJAXRS() throws Exception {
org.junit.Assert.assertEquals(2 * numToDouble, resp);
}
+ @org.junit.Test
+ public void testKerberosTokenJAXRSCustomLogin() throws Exception {
Review comment:
This test class is not actually run (there is a junit Ignore specified on
the class). Could you instead move the test to the systests/kerberos directory?
https://github.com/apache/cxf/tree/master/systests/kerberos/src/test/java/org/apache/cxf/systest/kerberos/jaxrs/kerberos
The test should show the need for this PR by failing before the fix was
applied, and passing after.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> LoginConfig in AbstractSpnegoAuthSupplier is not used
> -----------------------------------------------------
>
> Key: CXF-7867
> URL: https://issues.apache.org/jira/browse/CXF-7867
> Project: CXF
> Issue Type: Bug
> Components: Transports
> Reporter: Nicholas DiPiazza
> Assignee: Freeman Fang
> Priority: Minor
>
> We allow users to set the loginConfig in the AbstractSpnegoAuthSupplier
> But we do not use it. See:
> https://github.com/apache/cxf/blob/master/rt/transports/http/src/main/java/org/apache/cxf/transport/http/auth/AbstractSpnegoAuthSupplier.java#L116
> for its only usage.
> Unless I'm not understanding something, we should allow people to use it.
> Possibly naive PR: https://github.com/apache/cxf/pull/456
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
