[ 
https://issues.apache.org/jira/browse/CXF-8762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17609987#comment-17609987
 ] 

Radovan Netuka edited comment on CXF-8762 at 9/27/22 11:09 AM:
---------------------------------------------------------------

[~avi5kdonrh] I'm not sure that this is a bug. You are putting the unquoted 
value there _yourself_ in the test{_}.{_} Check 
[https://github.com/avi5kdonrh/cxf/blob/cxf-soap-action/rt/bindings/soap/src/test/java/org/apache/cxf/binding/soap/interceptor/SOAPActionWithoutQuotesTest.java#L43.]
 

 

If you do not put any PROTOCOL_HEADERS in this test, it works fine and the 
value is created correctly as a quoted string.

 

This is more auto-correcting wrong user input than a bug. It only happens if 
the SOAPAction header was already provided with incorrect value.


was (Author: rnetuka):
[~avi5kdonrh] I'm not sure that this is a bug. You are putting the unquoted 
value there _yourself_ in the test{_}.{_} Check 
[https://github.com/avi5kdonrh/cxf/blob/cxf-soap-action/rt/bindings/soap/src/test/java/org/apache/cxf/binding/soap/interceptor/SOAPActionWithoutQuotesTest.java#L43.]
 

 

If you do not put any PROTOCOL_HEADERS in this test, it works fine and the 
value is created correctly as a quoted string.

> CXF client sends the SOAPAction header without quotes
> -----------------------------------------------------
>
>                 Key: CXF-8762
>                 URL: https://issues.apache.org/jira/browse/CXF-8762
>             Project: CXF
>          Issue Type: Bug
>            Reporter: Avinash Dongre
>            Priority: Major
>         Attachments: proposed_fix.patch
>
>
> A Camel CXF client that works similarly to 
> [this|https://github.com/avi5kdonrh/cxf/blob/a7e8f9aa48656b1b7cc6458edb3bb60da7439d96/rt/bindings/soap/src/test/java/org/apache/cxf/binding/soap/interceptor/SOAPActionWithoutQuotesTest.java#L39-L43]
>  test case,  doesn't send the SOAPAction header in double quotes which breaks 
> [this|http://www.ws-i.org/Profiles/BasicProfile-1.1.html#SOAPAction_HTTP_Header]
>  specification.
> The said [test 
> case|https://github.com/avi5kdonrh/cxf/blob/cxf-soap-action/rt/bindings/soap/src/test/java/org/apache/cxf/binding/soap/interceptor/SOAPActionWithoutQuotesTest.java]
>  fails:
> org.junit.ComparisonFailure: 
> Expected :"http://foo/bar/SEI/opReq";
> Actual   :[http://foo/bar/SEI/opReq]
> It seems to be caused by this change:
> [https://github.com/apache/cxf/pull/307/files]
> Proposed fix.
> [https://github.com/apache/cxf/commit/66835e3db93ffa1cf7ab1df51ccd8c99fe6b1785?diff=split]
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to