[ 
https://issues.apache.org/jira/browse/DRILL-2142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14302024#comment-14302024
 ] 

Jason Altekruse commented on DRILL-2142:
----------------------------------------

Is there any reason not to use the pattern in the other repeated types, where a 
repeated wrapper is added around the scalar type? Rather than factoring out the 
common parts into a base class, it might be cleaner to compose the structure to 
be consistent with the other vector types.

> Refactor complex value vector classes
> -------------------------------------
>
>                 Key: DRILL-2142
>                 URL: https://issues.apache.org/jira/browse/DRILL-2142
>             Project: Apache Drill
>          Issue Type: Bug
>            Reporter: Mehant Baid
>            Assignee: Mehant Baid
>
> Currently we have one base class for the complex vectors. 
> AbstractContainerVector is the base class for RepeatedListVector, 
> RepeatedMapVector and MapVector. However lot of the functionality related to 
> maps in AbstractContainerVector is not needed by RepeatedListVector. In this 
> patch I would like to move all the map related logic to a new base class 
> called AbstractMapVector which would be used by RepeatedMap and Map classes. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to