[ https://issues.apache.org/jira/browse/DRILL-1875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacques Nadeau updated DRILL-1875: ---------------------------------- Priority: Major (was: Critical) > VectorContainder.getTransferClone() doesn't seem to handle ignoreWrappers > properly > ---------------------------------------------------------------------------------- > > Key: DRILL-1875 > URL: https://issues.apache.org/jira/browse/DRILL-1875 > Project: Apache Drill > Issue Type: Task > Components: Execution - Data Types > Reporter: Deneche A. Hakim > > Looking at org.apache.drill.exec.record.VectorContainer: > {code} > public static VectorContainer getTransferClone(VectorAccessible incoming, > VectorWrapper[] ignoreWrappers) { > VectorContainer vc = new VectorContainer(); > for (VectorWrapper<?> w : incoming) { > if(ignoreWrappers != null) { > for(VectorWrapper wrapper : ignoreWrappers) { > if (w == wrapper) { > continue; > } > } > } > vc.cloneAndTransfer(w); > } > return vc; > } > {code} > The inner loop doesn't seem to do anything. Shouldn't the continue statement > actually continue the outer loop instead ? like this: > {code} > outerloop: > for (VectorWrapper<?> w : incoming) { > if(ignoreWrappers != null) { > for(VectorWrapper wrapper : ignoreWrappers) { > if (w == wrapper) { > continue outerloop; > } > } > } > vc.cloneAndTransfer(w); > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)