[ https://issues.apache.org/jira/browse/DRILL-2597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14383483#comment-14383483 ]
Julian Hyde commented on DRILL-2597: ------------------------------------ SQL supports both kinds of comments: {code}<comment> ::= <simple comment> | <bracketed comment> <simple comment> ::= <simple comment introducer> [ <comment character>... ] <newline> <simple comment introducer> ::= <minus sign><minus sign> <bracketed comment> ::= <bracketed comment introducer> <bracketed comment contents> <bracketed comment terminator> <bracketed comment introducer> ::= /* <bracketed comment terminator> ::= */{code} So sqlline should send comments to JDBC as if they were commands, and Drill's SQL parser should deal with them. > Sqlline fails when script contains comments > ------------------------------------------- > > Key: DRILL-2597 > URL: https://issues.apache.org/jira/browse/DRILL-2597 > Project: Apache Drill > Issue Type: Bug > Components: Client - CLI > Affects Versions: 0.8.0 > Reporter: Abhishek Girish > Assignee: Daniel Barclay (Drill) > > Sqlline fails if option -f or --run= is used, and the DDL file contains a > comment. > *File contents:* > {code} > -- comments > drop view abc; > create view abc; > {code} > *Fails to recognize comments starting with -- * > {code} > ${DRILL_HOME}/bin/sqlline -u "jdbc:drill:schema=dfs.tmp" --run=abc.sql > Drill log directory: /opt/mapr/drill/drill-0.8.0/logs > 1/50 -- comments > Aborting command set because "force" is false and command failed: "-- > comments " > Closing: org.apache.drill.jdbc.DrillJdbc41Factory$DrillJdbc41Connection > sqlline version 1.1.6 > # ${DRILL_HOME}/bin/sqlline -u "jdbc:drill:schema=dfs.tmp" -f abc.sql > Drill log directory: /opt/mapr/drill/drill-0.8.0/logs > 1/50 -- comments > Aborting command set because "force" is false and command failed: "-- comment" > Closing: org.apache.drill.jdbc.DrillJdbc41Factory$DrillJdbc41Connection > sqlline version 1.1.6 > {code} > However, it does recognizes comments enclosed within /* ... */ -- This message was sent by Atlassian JIRA (v6.3.4#6332)