[
https://issues.apache.org/jira/browse/DRILL-2244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14384290#comment-14384290
]
Victoria Markman commented on DRILL-2244:
-----------------------------------------
Note for QA: test suite under Functional/Passing/joins/implicit_cast should be
executed with slice_target=1 in order to make sure that his bug is fixed.
Currently these are the cases where we return incorrect result:
{code}
Summary
----------------------------------------------------------------------------------------------------------------
Execution Failures:
Verification Failures
/root/drill-tests-vm/framework/resources/Functional/Passing/joins/implicit_cast/on_d28_and_c_integer.sql
/root/drill-tests-vm/framework/resources/Functional/Passing/joins/implicit_cast/on_d9_and_c_bigint.sql
/root/drill-tests-vm/framework/resources/Functional/Passing/joins/implicit_cast/on_c_float_and_c_integer.sql
/root/drill-tests-vm/framework/resources/Functional/Passing/joins/implicit_cast/on_d38_and_c_bigint.sql
/root/drill-tests-vm/framework/resources/Functional/Passing/joins/implicit_cast/on_c_bigint_and_d18.sql
/root/drill-tests-vm/framework/resources/Functional/Passing/joins/implicit_cast/on_d28_and_c_float.sql
/root/drill-tests-vm/framework/resources/Functional/Passing/joins/implicit_cast/on_c_integer_and_c_float.sql
/root/drill-tests-vm/framework/resources/Functional/Passing/joins/implicit_cast/on_d38_and_c_float.sql
/root/drill-tests-vm/framework/resources/Functional/Passing/joins/implicit_cast/on_d18_and_c_bigint.sql
/root/drill-tests-vm/framework/resources/Functional/Passing/joins/implicit_cast/on_c_integer_and_d18.sql
/root/drill-tests-vm/framework/resources/Functional/Passing/joins/implicit_cast/on_c_float_and_d38.sql
/root/drill-tests-vm/framework/resources/Functional/Passing/joins/implicit_cast/on_c_bigint_and_d28.sql
/root/drill-tests-vm/framework/resources/Functional/Passing/joins/implicit_cast/on_c_float_and_d18.sql
/root/drill-tests-vm/framework/resources/Functional/Passing/joins/implicit_cast/on_c_integer_and_c_double.sql
/root/drill-tests-vm/framework/resources/Functional/Passing/joins/implicit_cast/on_c_integer_and_d9.sql
/root/drill-tests-vm/framework/resources/Functional/Passing/joins/implicit_cast/on_d9_and_c_float.sql
/root/drill-tests-vm/framework/resources/Functional/Passing/joins/implicit_cast/on_d18_and_c_float.sql
/root/drill-tests-vm/framework/resources/Functional/Passing/joins/implicit_cast/on_c_bigint_and_c_integer.sql
/root/drill-tests-vm/framework/resources/Functional/Passing/joins/implicit_cast/on_c_float_and_d28.sql
/root/drill-tests-vm/framework/resources/Functional/Passing/joins/implicit_cast/on_c_float_and_c_double.sql
/root/drill-tests-vm/framework/resources/Functional/Passing/joins/implicit_cast/on_c_bigint_and_c_float.sql
/root/drill-tests-vm/framework/resources/Functional/Passing/joins/implicit_cast/on_d9_and_c_integer.sql
/root/drill-tests-vm/framework/resources/Functional/Passing/joins/implicit_cast/on_c_double_and_c_float.sql
/root/drill-tests-vm/framework/resources/Functional/Passing/joins/implicit_cast/on_c_bigint_and_c_double.sql
/root/drill-tests-vm/framework/resources/Functional/Passing/joins/implicit_cast/on_c_float_and_c_bigint.sql
/root/drill-tests-vm/framework/resources/Functional/Passing/joins/implicit_cast/on_d38_and_c_integer.sql
/root/drill-tests-vm/framework/resources/Functional/Passing/joins/implicit_cast/on_c_integer_and_c_bigint.sql
/root/drill-tests-vm/framework/resources/Functional/Passing/joins/implicit_cast/on_c_bigint_and_d38.sql
/root/drill-tests-vm/framework/resources/Functional/Passing/joins/implicit_cast/on_c_double_and_c_bigint.sql
/root/drill-tests-vm/framework/resources/Functional/Passing/joins/implicit_cast/on_c_integer_and_d38.sql
/root/drill-tests-vm/framework/resources/Functional/Passing/joins/implicit_cast/on_c_float_and_d9.sql
/root/drill-tests-vm/framework/resources/Functional/Passing/joins/implicit_cast/on_d28_and_c_bigint.sql
/root/drill-tests-vm/framework/resources/Functional/Passing/joins/implicit_cast/on_c_integer_and_d28.sql
/root/drill-tests-vm/framework/resources/Functional/Passing/joins/implicit_cast/on_c_bigint_and_d9.sql
/root/drill-tests-vm/framework/resources/Functional/Passing/joins/implicit_cast/on_c_double_and_c_integer.sql
/root/drill-tests-vm/framework/resources/Functional/Passing/joins/implicit_cast/on_d18_and_c_integer.sql
Timeout Failures
----------------------------------------------------------------------------------------------------------------
Passing tests: 20
Execution Failures: 0
VerificationFailures: 36
Timeouts: 0
{code}
> Implicit cast between decimal data types is not implemented
> -----------------------------------------------------------
>
> Key: DRILL-2244
> URL: https://issues.apache.org/jira/browse/DRILL-2244
> Project: Apache Drill
> Issue Type: Improvement
> Components: Execution - Codegen
> Affects Versions: 0.8.0
> Reporter: Victoria Markman
> Assignee: Mehant Baid
> Fix For: 0.9.0
>
> Attachments: DRILL-2244.patch
>
>
> I created two tables in drill with the following schema:
> t1.c1 - decimal(8,2)
> t2.c1 - decimal(18,4)
> Attempt to join on these columns produces run time error on not implemented
> compare function.
> Since we do support cast from INT to BIGINT, this behavior is inconsistent.
> {code}
> 0: jdbc:drill:schema=dfs> select * from x1, x2 where x1.c1 = x2.c1;
> Query failed: RemoteRpcException: Failure while running fragment., Failure
> finding function that runtime code generation expected. Signature:
> compare_to( DECIMAL9:OPTIONALDECIMAL18:OPTIONAL, ) returns INT:REQUIRED [
> 53049aa6-7165-4e5a-9dc5-9efa832b4e49 on atsqa4-134.qa.lab:31010 ]
> [ 53049aa6-7165-4e5a-9dc5-9efa832b4e49 on atsqa4-134.qa.lab:31010 ]
> Error: exception while executing query: Failure while executing query.
> (state=,code=0)
> {code}
> Explicit cast works:
> {code}
> 0: jdbc:drill:schema=dfs> select * from x1 left outer join x2 on cast(x1.c1
> as decimal(18,2)) = x2.c1;
> +------------+------------+
> | c1 | c10 |
> +------------+------------+
> | 1032.65 | null |
> +------------+------------+
> 1 row selected (0.137 seconds)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
