[ 
https://issues.apache.org/jira/browse/DRILL-2691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14534865#comment-14534865
 ] 

Jason Altekruse commented on DRILL-2691:
----------------------------------------

The patch is not applying cleanly, it doesn't look like git works well trying 
to track line ending changes with patch files. I might be doing something 
wrong, but I think whoever commits this is going to have to just manually make 
the change and commit it from their repo. I am +1 on the change and I will try 
to make this change myself soon and commit it.

> Source files with Windows line endings
> --------------------------------------
>
>                 Key: DRILL-2691
>                 URL: https://issues.apache.org/jira/browse/DRILL-2691
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Tools, Build & Test
>    Affects Versions: 0.6.0
>            Reporter: Deneche A. Hakim
>            Assignee: Jason Altekruse
>             Fix For: 1.0.0
>
>         Attachments: DRILL-2691.1.patch.txt
>
>
> The following files:
> {noformat}
> common/src/main/java/org/apache/drill/common/util/DrillStringUtils.java
> contrib/storage-hbase/src/test/java/org/apache/drill/hbase/TestHBaseCFAsJSONString.java
> {noformat}
> Have Windows line endings in them. Trying to apply a patch that contains 
> changes in one of those files will fail.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to