[ https://issues.apache.org/jira/browse/DRILL-3354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14601525#comment-14601525 ]
Deneche A. Hakim commented on DRILL-3354: ----------------------------------------- [~jaltekruse] can you please review [#35881|https://reviews.apache.org/r/35881/] ? > TestBuilder can check if the number of result batches equals some expected > value > -------------------------------------------------------------------------------- > > Key: DRILL-3354 > URL: https://issues.apache.org/jira/browse/DRILL-3354 > Project: Apache Drill > Issue Type: Improvement > Components: Tools, Build & Test > Reporter: Deneche A. Hakim > Assignee: Deneche A. Hakim > Priority: Minor > Fix For: 1.1.0 > > Attachments: DRILL-3354.1.patch.txt > > > TestWindowFrame unit tests are only meaningful if memory sort exposes batches > of a specific size (20 rows) downstream. Otherwise, the tests will pass but > they won't catch problems related to some specific edge cases when multiple > batches are involved. > The purpose of this JIRA is to extend TestBuilder so that unit tests that > wish to do so, to fail if the number of result batches differs from some > expected number. -- This message was sent by Atlassian JIRA (v6.3.4#6332)