[ https://issues.apache.org/jira/browse/DRILL-3445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14610888#comment-14610888 ]
Deneche A. Hakim commented on DRILL-3445: ----------------------------------------- [~hgunes] can you please review [#36103|https://reviews.apache.org/r/36103/] ? thx > BufferAllocator.buffer() implementations should throw an > OutOfMemoryRuntimeException > ------------------------------------------------------------------------------------ > > Key: DRILL-3445 > URL: https://issues.apache.org/jira/browse/DRILL-3445 > Project: Apache Drill > Issue Type: Bug > Components: Execution - Data Types, Execution - Relational Operators > Affects Versions: 1.0.0 > Reporter: Deneche A. Hakim > Assignee: Hanifi Gunes > Fix For: 1.2.0 > > Attachments: DRILL-3445.1.patch.txt > > > current implementations of BufferAllocator.buffer() return null if it can't > allocate the buffer because of direct memory or fragment limits., but many > places in the code don't actually check if the buffer is null before trying > to access it, this will result in confusing NullPointerException(s) when we > are in fact running out of memory. > We should change the implementations to throw an OutOfMemoryRuntimeException > instead. Drill already handles this exception properly in most cases and > displays a proper error message to the user. -- This message was sent by Atlassian JIRA (v6.3.4#6332)