[ https://issues.apache.org/jira/browse/DRILL-3189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14615612#comment-14615612 ]
Sean Hsuan-Yi Chu commented on DRILL-3189: ------------------------------------------ We might need to disable "disallow partial" only because, by default (i.e., not specify disallow/allow partial), Calcite assumes partial is allowed. More information is bellow (From Calcite's java doc): "Returns whether partial windows are allowed. If false, a partial window (for example, a window of size 1 hour which has only 45 minutes of data in it) will appear to windowed aggregate functions to be empty." > Disable ALLOW PARTIAL/DISALLOW PARTIAL in window function grammar > ----------------------------------------------------------------- > > Key: DRILL-3189 > URL: https://issues.apache.org/jira/browse/DRILL-3189 > Project: Apache Drill > Issue Type: Bug > Components: Query Planning & Optimization > Affects Versions: 1.0.0 > Reporter: Victoria Markman > Assignee: Sean Hsuan-Yi Chu > Priority: Critical > Labels: window_function > Fix For: 1.2.0 > > > It does not seem to be implemented on the drill side. Looks like Calcite > specific grammar. Don't see it SQL Standard. > Looks like wrong result: > {code} > 0: jdbc:drill:schema=dfs> select a2, sum(a2) over(partition by a2 order by a2 > rows between 1 preceding and 1 following disallow partial) from t2 order by > a2; > +-----+---------+ > | a2 | EXPR$1 | > +-----+---------+ > | 0 | null | > | 1 | null | > | 2 | 6 | > | 2 | 6 | > | 2 | 6 | > | 3 | null | > | 4 | null | > | 5 | null | > | 6 | null | > | 7 | 14 | > | 7 | 14 | > | 8 | null | > | 9 | null | > +-----+---------+ > 13 rows selected (0.213 seconds) > {code} > {code} > 0: jdbc:drill:schema=dfs> select a2, sum(a2) over(partition by a2 order by a2 > rows between 1 preceding and 1 following allow partial) from t2 order by a2; > +-----+---------+ > | a2 | EXPR$1 | > +-----+---------+ > | 0 | 0 | > | 1 | 1 | > | 2 | 6 | > | 2 | 6 | > | 2 | 6 | > | 3 | 3 | > | 4 | 4 | > | 5 | 5 | > | 6 | 6 | > | 7 | 14 | > | 7 | 14 | > | 8 | 8 | > | 9 | 9 | > +-----+---------+ > 13 rows selected (0.208 seconds) > {code} > {code} > 0: jdbc:drill:schema=dfs> select a2, sum(a2) over(partition by a2 order by a2 > disallow partial) from t2 order by a2; > Error: PARSE ERROR: From line 1, column 53 to line 1, column 68: Cannot use > DISALLOW PARTIAL with window based on RANGE > [Error Id: 984c4b81-9eb0-401d-b36a-9580640b4a78 on atsqa4-133.qa.lab:31010] > (state=,code=0) > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)