[ https://issues.apache.org/jira/browse/DRILL-3497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14637962#comment-14637962 ]
ASF GitHub Bot commented on DRILL-3497: --------------------------------------- GitHub user sudheeshkatkam opened a pull request: https://github.com/apache/drill/pull/98 DRILL-3497: Throw UserException#validationError for errors when modifying options Mistakenly closed https://github.com/apache/drill/pull/91. Please review 4c2b698. You can merge this pull request into a Git repository by running: $ git pull https://github.com/sudheeshkatkam/drill DRILL-3497 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/drill/pull/98.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #98 ---- commit 9dc056ec9f60b0e91acd345ca496a7e6fc077c05 Author: Sudheesh Katkam <skat...@maprtech.com> Date: 2015-07-22T23:32:02Z DRILL-2304: Manage options with lowercase names Major refactoring: + Removed unnecessary methods from OptionManagers, and refactored implementations + Removed OptionAdmin interface, which was a delegate to validators Other fixes: + Added CaseInsensitiveMap + Moved OptionValue creation from TypeValidators to SetOptionHandler + Fixed error message in BaseOptionManager + Added documentation for all OptionManagers, and OptionValidator commit 4c2b698fe5c059c7987c808e7e90f55659b74ba5 Author: Sudheesh Katkam <skat...@maprtech.com> Date: 2015-07-14T22:33:30Z DRILL-3497: Throw UserException#validationError instead of SetOptionException and ExpressionParsingException for options + Fixed bug in PositiveLongValidator (0 is not positive) + Added UserExceptionMatcher for unit tests ---- > Throw UserException#validationError for errors when modifying options > --------------------------------------------------------------------- > > Key: DRILL-3497 > URL: https://issues.apache.org/jira/browse/DRILL-3497 > Project: Apache Drill > Issue Type: Bug > Components: Execution - Flow > Reporter: Sudheesh Katkam > Assignee: Sudheesh Katkam > Priority: Minor > Fix For: 1.2.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)