[
https://issues.apache.org/jira/browse/DRILL-3535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14724803#comment-14724803
]
ASF GitHub Bot commented on DRILL-3535:
---------------------------------------
Github user jacques-n commented on a diff in the pull request:
https://github.com/apache/drill/pull/140#discussion_r38386206
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/BasicFormatMatcher.java
---
@@ -72,7 +72,7 @@ public boolean supportDirectoryReads() {
@Override
public FormatSelection isReadable(DrillFileSystem fs, FileSelection
selection) throws IOException {
- if (isReadable(fs, selection.getFirstPath(fs))) {
+ if (isFileReadable(fs, selection.getFirstPath(fs))) {
--- End diff --
I think we need to check all of the selection for Drop, not just the first.
Otherwise we risk blowing away a directory which has a bunch of files, where
only the first is readable. Right?
> Drop table support
> ------------------
>
> Key: DRILL-3535
> URL: https://issues.apache.org/jira/browse/DRILL-3535
> Project: Apache Drill
> Issue Type: New Feature
> Reporter: Mehant Baid
> Assignee: Mehant Baid
>
> Umbrella JIRA to track support for "Drop table" feature.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
