[ 
https://issues.apache.org/jira/browse/DRILL-3927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14957673#comment-14957673
 ] 

ASF GitHub Bot commented on DRILL-3927:
---------------------------------------

Github user adeneche commented on a diff in the pull request:

    https://github.com/apache/drill/pull/199#discussion_r42047219
  
    --- Diff: 
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillConnectionImpl.java ---
    @@ -369,24 +370,33 @@ AvaticaFactory getFactory() {
         return factory;
       }
     
    +  private static void closeOrWarn(final AutoCloseable autoCloseable, final 
String message, final Logger logger) {
    --- End diff --
    
    should we make this public and move this to 
`org.apache.drill.common.AutoCloseables` ?


> Use OutOfMemoryException in more places
> ---------------------------------------
>
>                 Key: DRILL-3927
>                 URL: https://issues.apache.org/jira/browse/DRILL-3927
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Execution - Flow
>            Reporter: Chris Westin
>            Assignee: Chris Westin
>
> The new allocator uses OutOfMemoryException in better ways; some additional 
> exception handling sites need to catch and handle this exception in 
> preparation for the new allocator.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to