[
https://issues.apache.org/jira/browse/DRILL-3662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14988244#comment-14988244
]
ASF GitHub Bot commented on DRILL-3662:
---------------------------------------
Github user amansinha100 commented on the pull request:
https://github.com/apache/drill/pull/222#issuecomment-153504706
+1. Per previous comments, there is room for improvement in terms of code
organization and reducing the number of passes which I understand will be
covered by DRILL-3662.
> Improve DefaultFrameTemplate structure
> --------------------------------------
>
> Key: DRILL-3662
> URL: https://issues.apache.org/jira/browse/DRILL-3662
> Project: Apache Drill
> Issue Type: Improvement
> Components: Execution - Relational Operators
> Reporter: Deneche A. Hakim
> Assignee: Deneche A. Hakim
> Labels: window_function
> Fix For: 1.3.0
>
>
> as part of the review for DRILL-3536 two main comments were left aside and
> will be addressed by this JIRA:
> - refactor DefaultFrameTemplate into separate templates, each one handles a
> different "family" of window functions (e.g. aggregate vs ranking)
> - setupEvaluatePeer() should not be called more than once per incoming batch
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
